diff --git a/test/org/ice4j/MessageEventDispatchingTest.java b/test/org/ice4j/MessageEventDispatchingTest.java index 720990b..4e48f10 100644 --- a/test/org/ice4j/MessageEventDispatchingTest.java +++ b/test/org/ice4j/MessageEventDispatchingTest.java @@ -316,12 +316,14 @@ public class MessageEventDispatchingTest extends TestCase * determined to be unreachable and that the request should be * considered unanswered. * - * @param exception the PortUnreachableException which signaled - * that the destination of the request was found to be unreachable - * @see ResponseCollector#processUnreachable(PortUnreachableException) + * @param event the StunFailureEvent + * PortUnreachableException which signaled that the destination + * of the request was found to be unreachable + * + * @see ResponseCollector#processUnreachable(StunFailureEvent) */ public synchronized void processUnreachable( - PortUnreachableException exception) + StunFailureEvent event) { receivedResponses.add("unreachable"); notifyAll(); diff --git a/test/org/ice4j/TransactionSupportTests.java b/test/org/ice4j/TransactionSupportTests.java index 8c1311a..3555b66 100644 --- a/test/org/ice4j/TransactionSupportTests.java +++ b/test/org/ice4j/TransactionSupportTests.java @@ -550,11 +550,13 @@ public class TransactionSupportTests extends TestCase * determined to be unreachable and that the request should be * considered unanswered. * - * @param exception the PortUnreachableException which signaled + * @param event the StunFailureEvent containing + * PortUnreachableException which signaled * that the destination of the request was found to be unreachable - * @see ResponseCollector#processUnreachable(PortUnreachableException) + * + * @see ResponseCollector#processUnreachable(StunFailureEvent) */ - public void processUnreachable(PortUnreachableException exception) + public void processUnreachable(StunFailureEvent event) { receivedResponses.add("unreachable"); } diff --git a/test/org/ice4j/stack/ShallowStackTest.java b/test/org/ice4j/stack/ShallowStackTest.java index 03c235e..6921a47 100644 --- a/test/org/ice4j/stack/ShallowStackTest.java +++ b/test/org/ice4j/stack/ShallowStackTest.java @@ -40,11 +40,21 @@ public class ShallowStackTest extends TestCase { private DatagramPacket bindingRequestPacket = new DatagramPacket(new byte[4096], 4096); + /** + * Creates a test instance for the method with the specified name. + * + * @param name the name of the test we'd like to create an instance for. + */ public ShallowStackTest(String name) { super(name); } + /** + * Initializes whatever sockets we'll be using in our tests. + * + * @throws Exception if something goes wrong with socket initialization. + */ protected void setUp() throws Exception { @@ -68,6 +78,11 @@ public class ShallowStackTest extends TestCase { dummyServerSocket = new DatagramSocket( dummyServerAddress ); } + /** + * Releases the sockets we use here. + * + * @throws Exception if closing the sockets fails. + */ protected void tearDown() throws Exception { @@ -234,6 +249,11 @@ public class ShallowStackTest extends TestCase { receivedResponse); // actual } + /** + * Performs a basic test on message reception + * + * @throws Exception if something fails somewhere. + */ public void testReceiveResponse() throws Exception { @@ -318,12 +338,14 @@ public class ShallowStackTest extends TestCase { * determined to be unreachable and that the request should be * considered unanswered. * - * @param exception the PortUnreachableException which signaled + * @param evt the StunFailureEvent containing the + * PortUnreachableException which signaled * that the destination of the request was found to be unreachable - * @see ResponseCollector#processUnreachable(PortUnreachableException) + * + * @see ResponseCollector#processUnreachable(StunFailureEvent) */ public synchronized void processUnreachable( - PortUnreachableException exception) + StunFailureEvent evt) { logger.info("Unreachable"); notifyAll();