Fixes warnings about redundant casts.

This commit is contained in:
lubomir.marinov 2010-02-02 09:27:28 +00:00
parent f9f88e4b14
commit 3497a43c8a
4 changed files with 10 additions and 19 deletions

View File

@ -25,7 +25,7 @@ public class EventDispatcher
/** /**
* All property change listeners registered so far. * All property change listeners registered so far.
*/ */
private Vector<RequestListener> requestListeners private final Vector<RequestListener> requestListeners
= new Vector<RequestListener>(); = new Vector<RequestListener>();
/** /**
@ -140,13 +140,8 @@ public class EventDispatcher
= new ArrayList<RequestListener>(requestListeners); = new ArrayList<RequestListener>(requestListeners);
} }
Iterator<RequestListener> iterator = listenersCopy.iterator(); for (RequestListener target : listenersCopy)
while (iterator.hasNext())
{
RequestListener target =
(RequestListener) iterator.next();
target.requestReceived(evt); target.requestReceived(evt);
}
} }
synchronized(requestListenersChildren) synchronized(requestListenersChildren)

View File

@ -420,7 +420,7 @@ public class StunStack
Enumeration<TransactionID> tids = clientTransactions.keys(); Enumeration<TransactionID> tids = clientTransactions.keys();
while (tids.hasMoreElements()) while (tids.hasMoreElements())
{ {
TransactionID item = (TransactionID)tids.nextElement(); TransactionID item = tids.nextElement();
StunClientTransaction tran = clientTransactions.remove(item); StunClientTransaction tran = clientTransactions.remove(item);
if(tran != null) if(tran != null)
tran.cancel(); tran.cancel();
@ -430,7 +430,7 @@ public class StunStack
tids = serverTransactions.keys(); tids = serverTransactions.keys();
while (tids.hasMoreElements()) while (tids.hasMoreElements())
{ {
TransactionID item = (TransactionID)tids.nextElement(); TransactionID item = tids.nextElement();
StunServerTransaction tran = serverTransactions.remove(item); StunServerTransaction tran = serverTransactions.remove(item);
if(tran != null) if(tran != null)
tran.expire(); tran.expire();

View File

@ -237,7 +237,7 @@ public class TransactionSupportTests extends TestCase
Vector<StunMessageEvent> reqs = requestCollector Vector<StunMessageEvent> reqs = requestCollector
.getRequestsForTransaction( bindingRequest.getTransactionID()); .getRequestsForTransaction( bindingRequest.getTransactionID());
StunMessageEvent evt = ((StunMessageEvent)reqs.get(0)); StunMessageEvent evt = reqs.get(0);
byte[] tid = evt.getMessage().getTransactionID(); byte[] tid = evt.getMessage().getTransactionID();
StunStack.getInstance().sendResponse( StunStack.getInstance().sendResponse(
@ -281,7 +281,7 @@ public class TransactionSupportTests extends TestCase
Vector<StunMessageEvent> reqs1 = requestCollector Vector<StunMessageEvent> reqs1 = requestCollector
.getRequestsForTransaction( bindingRequest.getTransactionID()); .getRequestsForTransaction( bindingRequest.getTransactionID());
StunMessageEvent evt1 = ((StunMessageEvent)reqs1.get(0)); StunMessageEvent evt1 = reqs1.get(0);
//send a response to make the other guy shut up //send a response to make the other guy shut up
byte[] tid = evt1.getMessage().getTransactionID(); byte[] tid = evt1.getMessage().getTransactionID();
@ -299,7 +299,7 @@ public class TransactionSupportTests extends TestCase
= requestCollector.getRequestsForTransaction( = requestCollector.getRequestsForTransaction(
bindingRequest.getTransactionID()); bindingRequest.getTransactionID());
StunMessageEvent evt2 = ((StunMessageEvent)reqs2.get(0)); StunMessageEvent evt2 = reqs2.get(0);
assertFalse("Consecutive requests were assigned the same transaction id", assertFalse("Consecutive requests were assigned the same transaction id",
Arrays.equals( evt1.getMessage().getTransactionID(), Arrays.equals( evt1.getMessage().getTransactionID(),
@ -440,12 +440,8 @@ public class TransactionSupportTests extends TestCase
{ {
Vector<StunMessageEvent> newVec = new Vector<StunMessageEvent>(); Vector<StunMessageEvent> newVec = new Vector<StunMessageEvent>();
Iterator<StunMessageEvent> reqsIter for (StunMessageEvent evt : receivedRequestsVector)
= receivedRequestsVector.iterator();
while(reqsIter.hasNext())
{ {
StunMessageEvent evt = (StunMessageEvent)reqsIter.next();
Message msg = evt.getMessage(); Message msg = evt.getMessage();
if( Arrays.equals(tranid, msg.getTransactionID())) if( Arrays.equals(tranid, msg.getTransactionID()))
newVec.add(evt); newVec.add(evt);

View File

@ -226,8 +226,8 @@ public class UnknownAttributesAttributeTest extends TestCase {
Iterator<Character> iterator = unknownAttributesAttribute.getAttributes(); Iterator<Character> iterator = unknownAttributesAttribute.getAttributes();
actualId1 = ((Character)iterator.next()).charValue(); actualId1 = iterator.next().charValue();
actualId2 = ((Character)iterator.next()).charValue();; actualId2 = iterator.next().charValue();;
assertEquals("getAttributes() return value mismatch", expectedId1, actualId1); assertEquals("getAttributes() return value mismatch", expectedId1, actualId1);
assertEquals("getAttributes() return value mismatch", expectedId2, actualId2); assertEquals("getAttributes() return value mismatch", expectedId2, actualId2);