From 48dde7ea8cbb58a621be3392c1049db3d7f93c89 Mon Sep 17 00:00:00 2001 From: "lubomir.marinov" Date: Thu, 4 Mar 2010 11:01:27 +0000 Subject: [PATCH] Fixes javadocs. --- src/org/ice4j/attribute/XorMappedAddressAttribute.java | 2 -- src/org/ice4j/stack/MessageProcessor.java | 8 ++++---- test/org/ice4j/MessageEventDispatchingTest.java | 9 +++++---- test/org/ice4j/TransactionSupportTests.java | 8 ++++---- test/org/ice4j/stack/ShallowStackTest.java | 7 +++++-- 5 files changed, 18 insertions(+), 16 deletions(-) diff --git a/src/org/ice4j/attribute/XorMappedAddressAttribute.java b/src/org/ice4j/attribute/XorMappedAddressAttribute.java index 96f67a9..90fbf3d 100644 --- a/src/org/ice4j/attribute/XorMappedAddressAttribute.java +++ b/src/org/ice4j/attribute/XorMappedAddressAttribute.java @@ -143,6 +143,4 @@ public class XorMappedAddressAttribute { return applyXor(getAddress(), xorMask); } - - } diff --git a/src/org/ice4j/stack/MessageProcessor.java b/src/org/ice4j/stack/MessageProcessor.java index 80acd95..d0fd318 100644 --- a/src/org/ice4j/stack/MessageProcessor.java +++ b/src/org/ice4j/stack/MessageProcessor.java @@ -95,7 +95,7 @@ class MessageProcessor { while (isRunning) { - RawMessage rawMessage = null; + RawMessage rawMessage; try { rawMessage = messageQueue.remove(); @@ -104,15 +104,15 @@ class MessageProcessor { if(isRunning()) logger.log(Level.WARNING, - "A net access point has gone useless:", ex); + "A net access point has gone useless: ", ex); //nothing to do here since we test whether we are running //just beneath ... + rawMessage = null; } // were we asked to stop? - if (!isRunning()){ + if (!isRunning()) return; - } //anything to parse? if (rawMessage == null) continue; diff --git a/test/org/ice4j/MessageEventDispatchingTest.java b/test/org/ice4j/MessageEventDispatchingTest.java index 0223b43..8d11404 100644 --- a/test/org/ice4j/MessageEventDispatchingTest.java +++ b/test/org/ice4j/MessageEventDispatchingTest.java @@ -312,13 +312,14 @@ public class MessageEventDispatchingTest extends TestCase } /** - * Stores incoming requests. + * Stores incoming responses. * - * @param responseEvt the event containing the incoming request. + * @param response a StunMessageEvent which describes the + * received STUN Response */ - public synchronized void processResponse(StunMessageEvent responseEvt) + public synchronized void processResponse(StunMessageEvent response) { - receivedResponses.add(responseEvt); + receivedResponses.add(response); notifyAll(); } diff --git a/test/org/ice4j/TransactionSupportTests.java b/test/org/ice4j/TransactionSupportTests.java index f11691b..9efdf2c 100644 --- a/test/org/ice4j/TransactionSupportTests.java +++ b/test/org/ice4j/TransactionSupportTests.java @@ -547,13 +547,13 @@ public class TransactionSupportTests extends TestCase } /** - * Logs the received responseEvt + * Logs the received response * - * @param responseEvt the event to log. + * @param response the event to log. */ - public void processResponse(StunMessageEvent responseEvt) + public void processResponse(StunMessageEvent response) { - receivedResponses.add(responseEvt); + receivedResponses.add(response); } } } diff --git a/test/org/ice4j/stack/ShallowStackTest.java b/test/org/ice4j/stack/ShallowStackTest.java index be38b4a..7f551f4 100644 --- a/test/org/ice4j/stack/ShallowStackTest.java +++ b/test/org/ice4j/stack/ShallowStackTest.java @@ -335,10 +335,13 @@ public class ShallowStackTest extends TestCase { /** * Logs the received response and notifies the wait method. + * + * @param response a StunMessageEvent which describes the + * received STUN Response */ - public synchronized void processResponse(StunMessageEvent evt) + public synchronized void processResponse(StunMessageEvent response) { - collectedResponse = (Response)evt.getMessage(); + collectedResponse = (Response) response.getMessage(); logger.finest("Received response."); notifyAll(); }