From d756d7d72ab6164e854714773bb07ed9e453375d Mon Sep 17 00:00:00 2001 From: Paul Gregoire Date: Thu, 5 Nov 2015 12:08:50 -0500 Subject: [PATCH 1/3] Added setting of packet port to 0 to prevent out-of-range error. --- src/main/java/org/ice4j/stack/Connector.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/main/java/org/ice4j/stack/Connector.java b/src/main/java/org/ice4j/stack/Connector.java index fb623d8..1a3200e 100644 --- a/src/main/java/org/ice4j/stack/Connector.java +++ b/src/main/java/org/ice4j/stack/Connector.java @@ -207,6 +207,13 @@ class Connector return; logger.finest("received datagram"); + logger.finest(String.format("packet - addr: %s port: %d", + packet.getAddress(), packet.getPort())); + if (packet.getPort() < 0) + { + // force a minimum port of 0 to prevent out of range errors + packet.setPort(0); + } RawMessage rawMessage = new RawMessage( From 3f9bf0b17cf8a5c32aa9c4e3898f3b24fcf1b5f5 Mon Sep 17 00:00:00 2001 From: Paul Gregoire Date: Thu, 5 Nov 2015 19:57:11 -0500 Subject: [PATCH 2/3] Merged log message --- src/main/java/org/ice4j/stack/Connector.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/java/org/ice4j/stack/Connector.java b/src/main/java/org/ice4j/stack/Connector.java index 1a3200e..4659bae 100644 --- a/src/main/java/org/ice4j/stack/Connector.java +++ b/src/main/java/org/ice4j/stack/Connector.java @@ -206,8 +206,7 @@ class Connector if(!running) return; - logger.finest("received datagram"); - logger.finest(String.format("packet - addr: %s port: %d", + logger.finest(String.format("received datagram packet - addr: %s port: %d", packet.getAddress(), packet.getPort())); if (packet.getPort() < 0) { From 39466ac70c9c4dfb856943a1c861e1b16773a2ff Mon Sep 17 00:00:00 2001 From: Paul Gregoire Date: Fri, 6 Nov 2015 08:43:58 -0500 Subject: [PATCH 3/3] Added warning log entry for out of range port on packet --- src/main/java/org/ice4j/stack/Connector.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/org/ice4j/stack/Connector.java b/src/main/java/org/ice4j/stack/Connector.java index 4659bae..83e8ea0 100644 --- a/src/main/java/org/ice4j/stack/Connector.java +++ b/src/main/java/org/ice4j/stack/Connector.java @@ -210,6 +210,7 @@ class Connector packet.getAddress(), packet.getPort())); if (packet.getPort() < 0) { + logger.warning("Out of range packet port, resetting to 0"); // force a minimum port of 0 to prevent out of range errors packet.setPort(0); }