diff --git a/src/main/java/org/ice4j/ice/Agent.java b/src/main/java/org/ice4j/ice/Agent.java index 3dc16ca..87256fe 100644 --- a/src/main/java/org/ice4j/ice/Agent.java +++ b/src/main/java/org/ice4j/ice/Agent.java @@ -410,7 +410,6 @@ public class Agent * * @param stream the {@link IceMediaStream} that the new {@link Component} * should belong to. - * @param transport the transport protocol used by the component * @param preferredPort the port number that should be tried first when * binding local Candidate sockets for this Component. * @param minPort the port number where we should first try to bind before @@ -430,21 +429,20 @@ public class Agent * minPort and maxPort before reaching the maximum allowed * number of retries. */ - public Component createComponent( IceMediaStream stream, - Transport transport, - int preferredPort, - int minPort, - int maxPort) + public Component createComponent( + IceMediaStream stream, + int preferredPort, + int minPort, + int maxPort) throws IllegalArgumentException, IOException, BindException { return createComponent( - stream, transport, + stream, preferredPort, minPort, maxPort, KeepAliveStrategy.SELECTED_ONLY, - StackProperties.getBoolean( - StackProperties.USE_COMPONENT_SOCKET, true)); + StackProperties.getBoolean(StackProperties.USE_COMPONENT_SOCKET, true)); } /** @@ -453,7 +451,6 @@ public class Agent * * @param stream the {@link IceMediaStream} that the new {@link Component} * should belong to. - * @param transport the transport protocol used by the component * @param preferredPort the port number that should be tried first when * binding local Candidate sockets for this Component. * @param minPort the port number where we should first try to bind before @@ -477,7 +474,6 @@ public class Agent */ public Component createComponent( IceMediaStream stream, - Transport transport, int preferredPort, int minPort, int maxPort, @@ -488,7 +484,6 @@ public class Agent { return createComponent( stream, - transport, preferredPort, minPort, maxPort, @@ -502,7 +497,6 @@ public class Agent * * @param stream the {@link IceMediaStream} that the new {@link Component} * should belong to. - * @param transport the transport protocol used by the component * @param preferredPort the port number that should be tried first when * binding local Candidate sockets for this Component. * @param minPort the port number where we should first try to bind before @@ -530,7 +524,6 @@ public class Agent */ public Component createComponent( IceMediaStream stream, - Transport transport, int preferredPort, int minPort, int maxPort, @@ -540,15 +533,7 @@ public class Agent IOException, BindException { - if (transport != Transport.UDP) - { - throw new IllegalArgumentException( - "This implementation does not currently support transport: " - + transport); - } - - Component component - = stream.createComponent(keepAliveStrategy, useComponentSocket); + Component component = stream.createComponent(keepAliveStrategy, useComponentSocket); gatherCandidates(component, preferredPort, minPort, maxPort); diff --git a/src/test/java/org/ice4j/ice/RoleConflictResolutionTest.java b/src/test/java/org/ice4j/ice/RoleConflictResolutionTest.java index 14acec9..202e71c 100644 --- a/src/test/java/org/ice4j/ice/RoleConflictResolutionTest.java +++ b/src/test/java/org/ice4j/ice/RoleConflictResolutionTest.java @@ -109,7 +109,6 @@ public class RoleConflictResolutionTest agent.createComponent( iceStream, - Transport.UDP, 0x400, 0x400, 0xFFFF, KeepAliveStrategy.ALL_SUCCEEDED, true); diff --git a/src/test/java/test/Ice.java b/src/test/java/test/Ice.java index 59beede..bea0a56 100644 --- a/src/test/java/test/Ice.java +++ b/src/test/java/test/Ice.java @@ -415,15 +415,13 @@ public class Ice //simultaneously with the others. //rtp - agent.createComponent( - stream, Transport.UDP, rtpPort, rtpPort, rtpPort + 100); + agent.createComponent(stream, rtpPort, rtpPort, rtpPort + 100); long endTime = System.currentTimeMillis(); logger.info("RTP Component created in " + (endTime - startTime) + " ms"); startTime = endTime; //rtcpComp - agent.createComponent( - stream, Transport.UDP, rtpPort + 1, rtpPort + 1, rtpPort + 101); + agent.createComponent(stream, rtpPort + 1, rtpPort + 1, rtpPort + 101); endTime = System.currentTimeMillis(); logger.info("RTCP Component created in " diff --git a/src/test/java/test/IcePseudoTcp.java b/src/test/java/test/IcePseudoTcp.java index b242dd8..454f5c7 100755 --- a/src/test/java/test/IcePseudoTcp.java +++ b/src/test/java/test/IcePseudoTcp.java @@ -107,8 +107,7 @@ public class IcePseudoTcp for (String hostname : hostnames) { agent.addCandidateHarvester(new TurnCandidateHarvester( - new TransportAddress(hostname, port, - Transport.UDP), longTermCredential)); + new TransportAddress(hostname, port, Transport.UDP), longTermCredential)); } } //STREAM @@ -127,8 +126,7 @@ public class IcePseudoTcp long startTime = System.currentTimeMillis(); //udp component - agent.createComponent( - stream, Transport.UDP, pTcpPort, pTcpPort, pTcpPort + 100); + agent.createComponent(stream, pTcpPort, pTcpPort, pTcpPort + 100); long endTime = System.currentTimeMillis(); logger.info("UDP Component created in " + (endTime - startTime) + " ms");