From 6bfe2ac5e54359413de3c913c30a1d590fd74224 Mon Sep 17 00:00:00 2001 From: Boris Grozev Date: Fri, 24 Feb 2017 09:34:55 -0600 Subject: [PATCH] feat: Allows adding sockets to an Agent late, after the Agent has completed/terminated. --- .../ice4j/ice/harvest/SinglePortUdpHarvester.java | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/ice4j/ice/harvest/SinglePortUdpHarvester.java b/src/main/java/org/ice4j/ice/harvest/SinglePortUdpHarvester.java index accb4a5..87d2bbe 100644 --- a/src/main/java/org/ice4j/ice/harvest/SinglePortUdpHarvester.java +++ b/src/main/java/org/ice4j/ice/harvest/SinglePortUdpHarvester.java @@ -26,7 +26,7 @@ import java.io.*; import java.net.*; import java.util.*; import java.util.concurrent.*; -import java.util.logging.Logger; // Disambiguation +import java.util.logging.*; /** * A harvester implementation which binds to a single DatagramSocket @@ -337,11 +337,16 @@ public class SinglePortUdpHarvester IceProcessingState state = component.getParentStream().getParentAgent().getState(); - if (!IceProcessingState.WAITING.equals(state) - && !IceProcessingState.RUNNING.equals(state)) + if (state == IceProcessingState.FAILED) { throw new IOException( - "Agent state is " + state + ". Cannot add socket."); + "Cannot add socket to an Agent in state FAILED."); + } + else if (state != null && state.isOver() + && logger.isLoggable(Level.FINE)) + { + logger.fine( + "Adding a socket to a completed Agent, state=" + state); } MultiplexingDatagramSocket multiplexing