From 7312077fd943d371cc2c222a14e23dc92de0a28f Mon Sep 17 00:00:00 2001 From: champtar Date: Mon, 9 May 2016 15:12:19 +0200 Subject: [PATCH] Ensure tieBreaker is positive (#71) Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE http://findbugs.sourceforge.net/bugDescriptions.html#RV_ABSOLUTE_VALUE_OF_RANDOM_INT Signed-off-by: Etienne CHAMPETIER --- src/main/java/org/ice4j/ice/Agent.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/ice4j/ice/Agent.java b/src/main/java/org/ice4j/ice/Agent.java index eaa71c2..6a1b0ea 100644 --- a/src/main/java/org/ice4j/ice/Agent.java +++ b/src/main/java/org/ice4j/ice/Agent.java @@ -315,7 +315,7 @@ public class Agent new BigInteger(128, random).toString(32), /* min */ 22, /* max */ 256); - tieBreaker = Math.abs(random.nextLong()); + tieBreaker = random.nextLong() & 0x7FFFFFFFFFFFFFFFL; nominator = new DefaultNominator(this); }