From abec6b79e564961575b3372a2ead52053dd3a67e Mon Sep 17 00:00:00 2001 From: Boris Grozev Date: Thu, 15 Dec 2016 10:44:57 -0600 Subject: [PATCH] fix: Only allow setting the keep-alive strategy before the Agent is started. --- src/main/java/org/ice4j/ice/Agent.java | 2 +- src/main/java/org/ice4j/ice/Component.java | 13 +++++++++++-- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/ice4j/ice/Agent.java b/src/main/java/org/ice4j/ice/Agent.java index dc732fa..0ee0a32 100644 --- a/src/main/java/org/ice4j/ice/Agent.java +++ b/src/main/java/org/ice4j/ice/Agent.java @@ -452,7 +452,7 @@ public class Agent IOException, BindException { - if(transport != Transport.UDP) + if (transport != Transport.UDP) { throw new IllegalArgumentException( "This implementation does not currently support transport: " diff --git a/src/main/java/org/ice4j/ice/Component.java b/src/main/java/org/ice4j/ice/Component.java index 0e18936..1110b85 100644 --- a/src/main/java/org/ice4j/ice/Component.java +++ b/src/main/java/org/ice4j/ice/Component.java @@ -1079,11 +1079,20 @@ public class Component /** * Sets the {@link KeepAliveStrategy} for this {@link Component}. - * @param strategy the strategy to set. + * @param strategy the strategy to set. The keep-alive strategy can only + * be modified before the parent {@link Agent} is started. + * @throws IllegalStateException if the agent has been started. */ public void setKeepAliveStrategy(KeepAliveStrategy strategy) { + IceProcessingState agentState + = getParentStream().getParentAgent().getState(); + if (!IceProcessingState.WAITING.equals(agentState)) + { + throw new IllegalStateException( + "Not changing the keep-alive strategy, the agent is is state " + + agentState); + } keepAliveStrategy = Objects.requireNonNull(strategy, "strategy"); } - }