Minor formatting changes, make methods package-private.

This commit is contained in:
boris 2015-03-30 10:49:23 +00:00
parent 03c5f7c162
commit b0c8e73b36
3 changed files with 36 additions and 33 deletions

View File

@ -1725,7 +1725,8 @@ public class Agent
if(!atLeastOneListSucceeded)
{
//all lists ended but none succeeded. No love today ;(
if (logger.isLoggable(Level.INFO)) {
if (logger.isLoggable(Level.INFO))
{
if (connCheckClient.isAlive()
|| connCheckServer.isAlive())
{

View File

@ -59,6 +59,20 @@ class ConnectivityCheckClient
*/
private boolean alive = false;
/**
* Creates a new <tt>ConnectivityCheckClient</tt> setting
* <tt>parentAgent</tt> as the agent that will be used for retrieving
* information such as user fragments for example.
*
* @param parentAgent the <tt>Agent</tt> that is creating this instance.
*/
public ConnectivityCheckClient(Agent parentAgent)
{
this.parentAgent = parentAgent;
stunStack = this.parentAgent.getStunStack();
}
/**
* Returns a boolean value indicating whether we have received a STUN
* response or not.
@ -72,22 +86,9 @@ class ConnectivityCheckClient
* @return a boolean value indicating whether we have received a STUN
* response or not.
*/
public boolean isAlive() {
return alive;
}
/**
* Creates a new <tt>ConnectivityCheckHandler</tt> setting
* <tt>parentAgent</tt> as the agent that will be used for retrieving
* information such as user fragments for example.
*
* @param parentAgent the <tt>Agent</tt> that is creating this instance.
*/
public ConnectivityCheckClient(Agent parentAgent)
boolean isAlive()
{
this.parentAgent = parentAgent;
stunStack = this.parentAgent.getStunStack();
return alive;
}
/**

View File

@ -53,23 +53,6 @@ class ConnectivityCheckServer
*/
private boolean alive = false;
/**
* Returns a boolean value indicating whether we have received a STUN
* request or not.
*
* Note that this should NOT be taken as an indication that the negotiation
* has succeeded, it merely indicates that we have received ANY STUN
* request, even invalid ones (e.g. with the wrong username or ufrag). It is
* completely unrelated/independent from the ICE spec and it's only meant to
* be used for debugging purposes.
*
* @return a boolean value indicating whether we have received a STUN
* request or not.
*/
public boolean isAlive() {
return alive;
}
/**
* Creates a new <tt>ConnectivityCheckServer</tt> setting
* <tt>parentAgent</tt> as the agent that will be used for retrieving
@ -87,6 +70,24 @@ class ConnectivityCheckServer
start();
}
/**
* Returns a boolean value indicating whether we have received a STUN
* request or not.
*
* Note that this should NOT be taken as an indication that the negotiation
* has succeeded, it merely indicates that we have received ANY STUN
* request, even invalid ones (e.g. with the wrong username or ufrag). It is
* completely unrelated/independent from the ICE spec and it's only meant to
* be used for debugging purposes.
*
* @return a boolean value indicating whether we have received a STUN
* request or not.
*/
boolean isAlive()
{
return alive;
}
/**
* Handles the {@link Request} delivered in <tt>evt</tt> by possibly
* queuing a triggered check and sending a success or an error response