From ca3868ac2643cedd3d60c31bbf9c4b11e0d41be8 Mon Sep 17 00:00:00 2001 From: Jonathan Lennox Date: Tue, 7 Apr 2020 18:25:16 -0400 Subject: [PATCH] Avoid double-nomination of ICE candidate pairs. (#198) Nomination is blocked once something is nominated rather than waiting until something is selected. --- src/main/java/org/ice4j/ice/DefaultNominator.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/ice4j/ice/DefaultNominator.java b/src/main/java/org/ice4j/ice/DefaultNominator.java index 321d2d5..ef88420 100644 --- a/src/main/java/org/ice4j/ice/DefaultNominator.java +++ b/src/main/java/org/ice4j/ice/DefaultNominator.java @@ -103,10 +103,12 @@ public class DefaultNominator return; CandidatePair validPair = (CandidatePair) ev.getSource(); + Component parentComponent = validPair.getParentComponent(); + IceMediaStream parentStream = parentComponent.getParentStream(); - // do not nominate pair if there is currently a selected pair for + // do not nominate pair if there is currently a nominated pair for // the component - if (validPair.getParentComponent().getSelectedPair() != null) + if (parentStream.validListContainsNomineeForComponent(parentComponent)) { logger.debug(() -> "Keep-alive for pair: " + validPair.toShortString());