From d4a145374f11ba07bf8407931bf4bd255a7a2e85 Mon Sep 17 00:00:00 2001 From: bgrozev Date: Wed, 29 Sep 2021 10:34:35 -0500 Subject: [PATCH] Add a log message when using StunMappingCandidateHarvester. (#238) * log: Add a log message when using StunMappingCandidateHarvester. * ref: Use lambda, fix formating. --- .../harvest/MappingCandidateHarvesters.java | 20 +++++++------------ 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/src/main/java/org/ice4j/ice/harvest/MappingCandidateHarvesters.java b/src/main/java/org/ice4j/ice/harvest/MappingCandidateHarvesters.java index cbfa661..d16ab34 100644 --- a/src/main/java/org/ice4j/ice/harvest/MappingCandidateHarvesters.java +++ b/src/main/java/org/ice4j/ice/harvest/MappingCandidateHarvesters.java @@ -199,8 +199,7 @@ public class MappingCandidateHarvesters if (face.getAddress().equals(h.getFace().getAddress()) && mask.getAddress().equals(h.getMask().getAddress())) { - logger.info("Discarding a mapping harvester with duplicate " - + "addresses: " + harvester + ". Kept: " + h); + logger.info("Discarding a mapping harvester with duplicate addresses: " + harvester + ". Kept: " + h); return; } } @@ -263,21 +262,17 @@ public class MappingCandidateHarvesters TransportAddress localAddress = new TransportAddress(localInetAddress, 0, Transport.UDP); + logger.info("Using " + remoteAddress + " for StunMappingCandidateHarvester (localAddress=" + + localAddress + ")."); final StunMappingCandidateHarvester stunHarvester = new StunMappingCandidateHarvester( localAddress, remoteAddress); - Callable task - = new Callable() + Callable task = () -> { - @Override - public StunMappingCandidateHarvester call() - throws Exception - { - stunHarvester.discover(); - return stunHarvester; - } + stunHarvester.discover(); + return stunHarvester; }; tasks.add(task); } @@ -285,8 +280,7 @@ public class MappingCandidateHarvesters // Now run discover() on all created harvesters in parallel and pick // the ones which succeeded. - ExecutorService es = ExecutorFactory.createFixedThreadPool(tasks.size(), - "ice4j.Harvester-executor-"); + ExecutorService es = ExecutorFactory.createFixedThreadPool(tasks.size(), "ice4j.Harvester-executor-"); try {