From e87d331e5798b0a85108ea0fd712b1c9e4200ea9 Mon Sep 17 00:00:00 2001 From: bgrozev Date: Fri, 8 Feb 2019 19:08:08 +0000 Subject: [PATCH] =?UTF-8?q?fix:=20Changes=20the=20fixed=20thread=20pool=20?= =?UTF-8?q?in=20NetAccessManager=20to=20an=20unbounde=E2=80=A6=20(#171)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: Changes the fixed thread pool in NetAccessManager to an unbounded cached thread pool. --- .../org/ice4j/stack/NetAccessManager.java | 4 +--- .../java/org/ice4j/util/ExecutorFactory.java | 20 +++++++++++++++++-- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/ice4j/stack/NetAccessManager.java b/src/main/java/org/ice4j/stack/NetAccessManager.java index 2c356b9..5747a6f 100644 --- a/src/main/java/org/ice4j/stack/NetAccessManager.java +++ b/src/main/java/org/ice4j/stack/NetAccessManager.java @@ -57,9 +57,7 @@ class NetAccessManager * {@link NetAccessManager}s. */ private static ExecutorService messageProcessingExecutor - = ExecutorFactory.createFixedThreadPool( - Runtime.getRuntime().availableProcessors(), - "ice4j.NetAccessManager-"); + = ExecutorFactory.createCachedThreadPool("ice4j.NetAccessManager-"); /** * Maximum number of {@link MessageProcessingTask} to keep in object pool. diff --git a/src/main/java/org/ice4j/util/ExecutorFactory.java b/src/main/java/org/ice4j/util/ExecutorFactory.java index 0477533..41528a9 100644 --- a/src/main/java/org/ice4j/util/ExecutorFactory.java +++ b/src/main/java/org/ice4j/util/ExecutorFactory.java @@ -112,7 +112,7 @@ public class ExecutorFactory executor.setKeepAliveTime(threadKeepAliveTime, timeUnit); executor.allowCoreThreadTimeOut(true); executor.setRemoveOnCancelPolicy(true); - return Executors.unconfigurableScheduledExecutorService(executor); + return executor; } /** @@ -135,6 +135,22 @@ public class ExecutorFactory new LinkedBlockingDeque<>(), threadFactory); executor.allowCoreThreadTimeOut(true); - return Executors.unconfigurableExecutorService(executor); + return executor; + } + + /** + * Creates an {@link ExecutorService} with an unlimited number of threads + * which are released after idle timeout. + * + * @param threadNamePrefix - name prefix for threads created by pool + * @return pre-configured {@link ExecutorService} + */ + public static ExecutorService createCachedThreadPool( + String threadNamePrefix) + { + final CustomizableThreadFactory threadFactory + = new CustomizableThreadFactory(threadNamePrefix, true); + + return Executors.newCachedThreadPool(threadFactory); } }