From eb0e3d3fb80984f0b2cf65ac2da383a5cfd48a35 Mon Sep 17 00:00:00 2001 From: Lyubomir Marinov Date: Thu, 24 Mar 2016 11:51:49 -0500 Subject: [PATCH] Implements (poor) hashCode() for CandidatePair and Candidate so they may at least be added to HashMap. --- src/main/java/org/ice4j/ice/Candidate.java | 14 ++++++++++++++ src/main/java/org/ice4j/ice/CandidatePair.java | 14 ++++++++++++++ 2 files changed, 28 insertions(+) diff --git a/src/main/java/org/ice4j/ice/Candidate.java b/src/main/java/org/ice4j/ice/Candidate.java index 81e8070..3a8f373 100644 --- a/src/main/java/org/ice4j/ice/Candidate.java +++ b/src/main/java/org/ice4j/ice/Candidate.java @@ -341,6 +341,20 @@ public abstract class Candidate> && getFoundation().equals(candidate.getFoundation()); } + /** + * {@inheritDoc} + */ + @Override + public int hashCode() + { + // Even if the following hashCode algorithm has drawbacks because of it + // simplicity, it is better than nothing because at least it allows + // Candidate and, respectively, CandidatePair to be used as HashMap + // keys. + return + getParentComponent().hashCode() + getTransportAddress().hashCode(); + } + /** * Returns a reference to the Component that this candidate belongs * to. diff --git a/src/main/java/org/ice4j/ice/CandidatePair.java b/src/main/java/org/ice4j/ice/CandidatePair.java index 026f508..265ae06 100644 --- a/src/main/java/org/ice4j/ice/CandidatePair.java +++ b/src/main/java/org/ice4j/ice/CandidatePair.java @@ -456,6 +456,20 @@ public class CandidatePair && remoteCandidate.equals(candidatePair.remoteCandidate); } + /** + * {@inheritDoc} + */ + @Override + public int hashCode() + { + // Even if the following hashCode algorithm has drawbacks because of it + // simplicity, it is better than nothing because at least it allows + // CandidatePair to be used as a HashMap key. + // XXX While localCandidate is not final, the parentComponent is + // supposedly effectively final. + return getLocalCandidate().getParentComponent().hashCode(); + } + /** * Returns a String representation of this CandidatePair. *