Compares tie breakers as unsigned longs to as RFC5245 mandates. Based on Matt Fredrickson's report and patch. Fixes #28.
This commit is contained in:
parent
1ba6076431
commit
eb35310969
@ -257,7 +257,7 @@ class ConnectivityCheckServer
|
|||||||
// contents of the ICE-CONTROLLING attribute, the agent generates
|
// contents of the ICE-CONTROLLING attribute, the agent generates
|
||||||
// a Binding error response and includes an ERROR-CODE attribute
|
// a Binding error response and includes an ERROR-CODE attribute
|
||||||
// with a value of 487 (Role Conflict) but retains its role.
|
// with a value of 487 (Role Conflict) but retains its role.
|
||||||
if( ourTieBreaker >= theirTieBreaker)
|
if(Long.compareUnsigned(ourTieBreaker, theirTieBreaker) >= 0)
|
||||||
{
|
{
|
||||||
Response response = MessageFactory.createBindingErrorResponse(
|
Response response = MessageFactory.createBindingErrorResponse(
|
||||||
ErrorCodeAttribute.ROLE_CONFLICT);
|
ErrorCodeAttribute.ROLE_CONFLICT);
|
||||||
@ -304,7 +304,7 @@ class ConnectivityCheckServer
|
|||||||
//If the agent's tie-breaker is larger than or equal to the
|
//If the agent's tie-breaker is larger than or equal to the
|
||||||
//contents of the ICE-CONTROLLED attribute, the agent switches to
|
//contents of the ICE-CONTROLLED attribute, the agent switches to
|
||||||
//the controlling role.
|
//the controlling role.
|
||||||
if(ourTieBreaker >= theirTieBreaker)
|
if(Long.compareUnsigned(ourTieBreaker, theirTieBreaker) >= 0)
|
||||||
{
|
{
|
||||||
logger.finer(
|
logger.finer(
|
||||||
"Switching to controlling because theirTieBreaker="
|
"Switching to controlling because theirTieBreaker="
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user