From f9a357ec17daa8b197d8ddbac49121f9af43a52a Mon Sep 17 00:00:00 2001 From: Reker Date: Tue, 12 Feb 2019 19:42:23 +0800 Subject: [PATCH] Fix SDP Connection field generation bug (#136) The signature of sdpFactory#createConnection is (String netType, String addrType, String addr), so IceSdpUtils always generate wrong Connection in SDP --- src/main/java/org/ice4j/ice/sdp/IceSdpUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/org/ice4j/ice/sdp/IceSdpUtils.java b/src/main/java/org/ice4j/ice/sdp/IceSdpUtils.java index a472b32..7efe91e 100644 --- a/src/main/java/org/ice4j/ice/sdp/IceSdpUtils.java +++ b/src/main/java/org/ice4j/ice/sdp/IceSdpUtils.java @@ -177,7 +177,7 @@ public class IceSdpUtils : Connection.IP4; mediaDescription.setConnection(sdpFactory.createConnection( - "IN", defaultAddress.getHostAddress(), addressFamily)); + "IN", addressFamily, defaultAddress.getHostAddress())); //now check if the RTCP port for the default candidate is different //than RTP.port +1, in which case we need to mention it.