806 Commits

Author SHA1 Message Date
Emil Ivov
2b8b025fbe Merge pull request #85 from bgrozev/configureble-so-rcvbuf
feat: Makes the single-port harvester's sockets' receive buffer sizes
2016-10-05 04:48:24 -05:00
Boris Grozev
84ca00a325 feat: Makes the single-port harvester's sockets' receive buffer sizes
configurable.
2016-10-05 11:28:21 +03:00
bgrozev
38cfe178c6 Merge pull request #83 from matteocampana/logging_improvement
Do not use String.format and construct the string only if logger…
2016-10-03 14:44:20 +03:00
Matteo Campana
350fb833ac Do not use String.format and construct the string only if logger FINEST is enabled. 2016-09-27 16:54:05 +02:00
Boris Grozev
3aaee5acde refactor: Expose a method. 2016-09-09 07:26:55 -05:00
Boris Grozev
4216982445 refactor: Extracts AbstractTcpListener from TcpHarvester. 2016-09-08 21:26:52 -05:00
Boris Grozev
35e603d346 refactor: Extracts an abstract base class from SinglePortUdpHarvester. 2016-09-08 13:20:31 -05:00
Boris Grozev
0abaef19e8 refactor: Splits CandidateHarvester into an interface
and an abstract implementation.
2016-09-08 12:09:34 -05:00
Дамян Минков
94b3cb2661 Merge pull request #80 from bgrozev/ufrag-prefix
feat: Adds an optional prefix to the local ufrag.
2016-09-06 16:04:59 -05:00
Boris Grozev
1dc41efb1e feat: Adds an optional prefix to the local ufrag. 2016-09-06 14:18:19 -05:00
Lyubomir Marinov
bed87bcbd3 Merge branch 'javadoc' 2016-08-26 13:39:21 -05:00
damencho
4ba7247480 Adds javadoc target. 2016-08-26 12:50:52 -05:00
Ingo Bauersachs
4e8f3474e7 Merge pull request #73 from ubivent-seuffert/pmaster
Handover IOException to higher level
2016-08-18 06:35:23 +02:00
George Politis
d6c4c62689 Merge pull request #77 from bgrozev/statistics
Exposes RateStatistics#getAccumulatedCount
2016-08-17 13:30:12 -05:00
Boris Grozev
a21088dc7a Exposes RateStatistics#getAccumulatedCount and
synchronizes access to some of the methods.
2016-08-11 16:37:36 -05:00
bgrozev
5f2261af43 Merge pull request #76 from jitsi/consent_freshness_config
Make "consent freshness" intervals configurable
2016-07-21 22:20:36 +02:00
paweldomas
58c319981c Make "consent freshness" intervals configurable 2016-07-21 15:01:30 -05:00
Ingo Bauersachs
26aa42cc37 Merge pull request #75 from bgrozev/improve-logging
Improve logging
2016-07-06 21:19:29 +02:00
Boris Grozev
6fe376a56d Lowers the log level of a message. 2016-07-06 12:45:27 -05:00
Boris Grozev
2af7613491 Lowers the log level of a message. 2016-07-06 12:04:03 -05:00
Boris Grozev
27f6f62c27 Include the local username fragment in various log messages. 2016-07-05 16:10:43 -05:00
Boris Grozev
dc29172a2c Introduces a separate log level for each Agent instance.
Makes instances belonging to an Agent use the log level from the Agent
instance.

The motivation is to disable logging output from Agents created
for the purposes of jitsi-videobridge health checks (but not other
Agents).
2016-07-05 15:31:50 -05:00
ubivent-seuffert
ded13aa230 Merge branch 'master' of https://github.com/jitsi/ice4j into pmaster 2016-06-01 16:15:55 +02:00
ubivent-seuffert
aa22012c5d throw needed exception 2016-06-01 16:15:34 +02:00
George Politis
4f946f38a4 Merge pull request #72 from bgrozev/fix-failiure-to-close
Fixes a failure to close a Socket instance.
2016-05-20 13:13:50 -05:00
Boris Grozev
568ace382b Fixes a failure to close a Socket instance.
Makes sure that Socket instances which are discarded because
they are only added after the corresponding ICE Agent has
moved away from the WAITING or RUNNING state are closed. This
prevents a file descriptor leak, since Socket instances which are
not closed (even after they are garbage collected) leave behind
sockets in state CLOSE_WAIT.
2016-05-20 11:38:22 -05:00
Boris Grozev
e4f5534b3d Minor fixes to the documentation. 2016-05-20 11:35:00 -05:00
champtar
7312077fd9 Ensure tieBreaker is positive (#71)
Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE
http://findbugs.sourceforge.net/bugDescriptions.html#RV_ABSOLUTE_VALUE_OF_RANDOM_INT

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
2016-05-09 15:12:19 +02:00
champtar
164ca04236 Drop MessageQueue, use a LinkedBlockingQueue instead (#63)
LinkedBlockingQueue are available since java 5

This is a bit more efficient as we were calling notifyAll()
instead of notify() in add(), thus waking up too much

This also remove 'logger.finest("Adding raw message to queue.");'

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
2016-05-06 20:03:52 +02:00
champtar
a363a973eb Use an ArrayList instead of reimplementing it (#62)
This should not change performance but is way more readable

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
2016-05-06 19:54:50 +02:00
Ingo Bauersachs
a51af3f90f Merge pull request #68 from champtar/ChannelData_padding
ChannelData: fix padding
2016-05-06 19:42:04 +02:00
Etienne CHAMPETIER
b76f9abfc9 ChannelData: fix decode()
I haven't found any user of this method.

This method was only working if offset == 0
and binMessage isn't a padded message.

arrayLen is useless as we have msgLen, so remove it,
and introduce a deprecated decode() to keep same api

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
2016-05-03 11:25:03 +02:00
Etienne CHAMPETIER
84bd07c665 Use new ChannelData.encode(pad)
Padding is mandatory for TCP and TLS
See https://tools.ietf.org/html/rfc5766#section-11.5

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
2016-05-03 11:25:03 +02:00
Etienne CHAMPETIER
d33d8b87e4 ChannelData: rework padding
getDataLength() was returning data length without
padding, so keep current behavior and update the javadoc.
(spotted with findbugs because length in
getDataLength was a dead store)

Introduce padTo4() to round up a number to the next
multiple of 4.

Deprecate encode() and introduce encode(boolean pad)
so we can let the caller decide if he wants padding
(mandatory when using tcp or tls)

See https://tools.ietf.org/html/rfc5766#section-11.5

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
2016-05-03 11:25:03 +02:00
Emil Ivov
b877467bc4 Merge pull request #58 from jitsi/remove-ant
Remove obsolete Ant-build and the embedded libraries
2016-05-02 17:44:41 -05:00
bgrozev
249ebb913a Merge pull request #65 from jitsi/fix-javadoc
Fix Javadoc formatting and missing parameters
2016-04-25 13:26:57 -05:00
Ingo Bauersachs
de1260610d Merge pull request #69 from champtar/nullequals
Remove unneeded null checks & fix MagicCookieAttribute equals
2016-04-20 22:15:05 +02:00
champtar
caa313739a Remove uneeded boxing/unboxing (#70)
http://findbugs.sourceforge.net/bugDescriptions.html#DM_BOXED_PRIMITIVE_FOR_PARSING

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
2016-04-20 22:12:53 +02:00
champtar
08f6ee8c64 org.ice4j.attribute: fix bytes conversion bugs (#67)
http://findbugs.sourceforge.net/bugDescriptions.html#BIT_IOR_OF_SIGNED_BYTE
http://findbugs.sourceforge.net/bugDescriptions.html#BIT_ADD_OF_SIGNED_BYTE

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
2016-04-20 22:02:15 +02:00
champtar
ce4126701e NetworkUtils: fix IndexOutOfBoundsException (#66)
http://findbugs.sourceforge.net/bugDescriptions.html#RANGE_ARRAY_LENGTH

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
2016-04-20 21:54:04 +02:00
Etienne CHAMPETIER
9155707329 Remove unneeded null checks in equals
instanceof already check for null

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
2016-04-19 10:41:20 +02:00
Etienne CHAMPETIER
af8c32ecd7 Fix MagicCookieAttribute equals
this looks like a copy/paste error

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
2016-04-19 10:41:18 +02:00
Ingo Bauersachs
7e152e0367 Add run targets that used to existed in Ant
mvn test-compile
mvn exec:java -Prun-<whatever>
2016-04-18 22:18:59 +02:00
Ingo Bauersachs
71b2874d46 Remove obsolete Ant-build and the embedded libraries 2016-04-18 22:14:02 +02:00
Ingo Bauersachs
02e1217144 Fix Javadoc formatting and missing parameters
This now satisfies Java 8's Javadoc compiler with it's default options.
2016-04-16 00:11:00 +02:00
lyubomir
8536ff347b Merge pull request #61 from jitsi/maven-release
Maven release 1.0
2016-04-04 17:10:53 -05:00
Ingo Bauersachs
0f0fb9d06f [maven-release-plugin] prepare for next development iteration 2016-04-04 23:40:28 +02:00
Ingo Bauersachs
a4aca5721d [maven-release-plugin] prepare release ice4j-1.0 ice4j-1.0 2016-04-04 23:40:22 +02:00
Ingo Bauersachs
dde63d6fc3 Add SCM data for maven-release-plugin 2016-04-04 23:39:04 +02:00
lyubomir
ce897fd796 Merge pull request #60 from jitsi/publish-central
Prepare releasing on Maven Central
2016-04-04 16:05:26 -05:00